Refactor pytest_collection_modify hook#107
Merged
Merged
Conversation
Member
Author
|
@Sheila-nk @melissawm any chance you could review this PR? Would be much appreciated. |
Member
Author
|
scipy/scipy#20112 should take care of |
c59a358 to
b877180
Compare
ev-br
commented
Feb 19, 2024
e4d3d36 to
09d0db6
Compare
09d0db6 to
6d3aaa0
Compare
Member
Author
|
Merging now to keep the ball rolling as I work on test errors after collection is successful. A post-merge review would still be most welcome. |
This was referenced Feb 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor the doctest collection stage a bit.
The key simplifications are
build-installfolder. Its contents matches the installed version, so it should be identical to$ pytest --pyargs scipyfor an installed scipy (I think?). This obviates the need for thePY_IGNORE_IMPORTMISMATCH=1env var --- almost. The remaining need seems to be due to some weirdness inscipy.signal, which indeed has a matching.pyand.somodules:This probably needs to be looked at on the scipy side.
pytest --collect-only ...and some light postprocessing (below the fold)The full stanza to run this, including pytest ignores, is currently (I know)
Log posprocessing scripts are below the fold:
Details
and
With these, the logs agree for the following combination: https://github.com/ev-br/scipy/tree/doctest_plugin + this PR, and scipy/scipy#16391, modulo #106.